-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set-AzStorageSyncServer: Fix string comparison and add scenario test #27041
Draft
stefong99
wants to merge
10
commits into
Azure:shared/StorageSync
Choose a base branch
from
stefong99:stefong/patchserver-improvements
base: shared/StorageSync
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Set-AzStorageSyncServer: Fix string comparison and add scenario test #27041
stefong99
wants to merge
10
commits into
Azure:shared/StorageSync
from
stefong99:stefong/patchserver-improvements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecate the Blueprints cmdlets. * Update Blueprint cmdlets deprecation messages and changelog. * Changing the deprecation message. * Update deprecation version. * Update blueprint version deprecation. --------- Co-authored-by: Dante DG <test>
* Move DataProtection to main * Update ChangeLog.md --------- Co-authored-by: Yan Xu <[email protected]>
* generate Synapse SDK by autorest csharp * batch sql gen 3 20200401preview * generate Synapse by autorest powershell and fix naming * Update ChangeLog.md * fix naming * Update README.md * add batch tag * delete KustoPool.json * Update README.md * update test * Update restore pool example by Q&A 2047354 * Credential Scanner Error fix * undo skip test case * generate Synapse SDK by autorest csharp * batch sql gen 3 20200401preview * generate Synapse by autorest powershell and fix naming * Update ChangeLog.md * fix naming * Update README.md * add batch tag * delete KustoPool.json * Update README.md * update test * Update restore pool example by Q&A 2047354 * Credential Scanner Error fix * undo skip test case * Update ChangeLog.md * Revert "Merge branch 'joyer/Synapse-sdk-migration' of https://github.com/Azure/azure-powershell into joyer/Synapse-sdk-migration" This reverts commit 89d95f2, reversing changes made to 1cdf198. * Update WorkspaceTests.ps1 * use common function to wait * format fix * format fix 2
* Move EventHub to main * Update ChangeLog.md * Update ChangeLog.md --------- Co-authored-by: Yan Xu <[email protected]>
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
…ng/patchserver-improvements
…tefong99/azure-powershell into stefong/patchserver-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a missing case insensitive string comparison and also adds a scenario test for the Set-AzStorageSyncServer commandlet.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.